✨ [WIP] Support multiple inputs #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding "feature" to support multiple inputs for kantra. That allows running analysis of multiple applications within a single kantra call and having results in a single statis report. Limitations: - analyses are executed serially one after another and there is _no_ plan on making it paralel (use full Konveyor if need this) - all options (like labels, rules) are shared for all inputs (again no plan on supporting per-input labels etc., use full Konveyor if needed) Since the multiple input analysis execution might take a while, static report is re-generated after each application analysis. Analysis YAML results and log are stored in single output directory in files with name suffix based on input name. Single-input analysis output structure is not changed. TODOs: - include dependencies files in outputs - consider support `input dir` with multiple applications if needed - optimize repeated execution of provider containers&related stuff setup and cleanup Fixes: https://github.com/konveyor/kantra/issues/180 Signed-off-by: Marek Aufart <[email protected]>
|
The original plan we discussed in analyzer team was sligthly more "hidden" multiple inputs functionality, but that has much more negative impact to users than on source code IMO. If we continue with approach single kantra call is single application analysis , I'd like suggest another solution adding just a |
aufi
added a commit
to aufi/kantra
that referenced
this pull request
May 31, 2024
It was requested to allow multiple inputs for kantra analyze command. Full multiple inputs support (or a limited/hidden input-bin directory support) would bring unwanted complications for codebase and unwanted usage of kantra tool instead of using Konveyor Hub (discussed in eng team). It looks much cleaner to me to state in README, that kantra analyze is intentionaly a single input command, but allow script multiple inputs analysis on user-side with --bulk command option, that allows run mutliple analysis into the same output directly and create a combined static report. Related to - https://github.com/konveyor/kantra/issues/180 - konveyor#234 (alternative) Signed-off-by: Marek Aufart <[email protected]>
|
Added an alternative PR #250 (that I like much more than this multile input or input-bin directory solution), but I'm ready finish this with input-bin dir if required. |
eemcmullan
added
the
do-not-merge/work-in-progress
aufi
added a commit
that referenced
this pull request
Jun 18, 2024
Support multiple inputs with bulk option It was requested to allow multiple inputs for kantra analyze command. Full multiple inputs support (or a limited/hidden input-bin directory support) would bring unwanted complications for codebase and unwanted usage of kantra tool instead of using Konveyor Hub (discussed in eng team). It looks much cleaner to me to state in README, that kantra analyze is intentionaly a single input command, but allow script multiple inputs analysis on user-side with --bulk command option, that allows run mutliple analysis into the same output directly and create a combined static report. Related to - https://github.com/konveyor/kantra/issues/180 - #234 (alternative) Signed-off-by: Marek Aufart <[email protected]> Signed-off-by: Marek Aufart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding "feature" to support multiple inputs for kantra. That allows running analysis of multiple applications within a single kantra call and having results in a single statis report.
Limitations:
Since the multiple input analysis execution might take a while, static report is re-generated after each application analysis. Analysis YAML results and log are stored in single output directory in files with name suffix based on input name.
Single-input analysis output structure is not changed.
TODOs:
input dirkantra argument with multiple applications if neededWork in progress, but works for me locally with 2 ear application inputs.
Related to konveyor/enhancements#194